Fix compilations warnings in libraries #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fac5664. Signed-off-by: Zbigniew Lukwinski <[email protected]>
This reverts commit db2b7ca. Signed-off-by: Zbigniew Lukwinski <[email protected]>
The following warning is being fixed:
warning: unused import: `CONSTRUCTED`
--> deps/spdm-rs/external/webpki/src/der.rs:17:24
|
17 | der::{nested, Tag, CONSTRUCTED},
That warning was already fixed with this patch:
briansmith/webpki@8f81719
Once webpki library version will be bumped up, this patch could be dropped.
Signed-off-by: Zbigniew Lukwinski <[email protected]>
The following warning is being fixed:
warning: unused imports: `PKCS1`, `PSS`
--> ring/src/rsa/padding.rs:21:13
|
21 | pkcs1::{PKCS1, RSA_PKCS1_SHA256, RSA_PKCS1_SHA384, RSA_PKCS1_SHA512},
| ^^^^^
22 | pss::{PSS, RSA_PSS_SHA256, RSA_PSS_SHA384, RSA_PSS_SHA512},
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
That warning was already fixed with this patch:
briansmith/ring@c4742e0
Once ring library version will be bumped up, this patch could be dropped.
Signed-off-by: Zbigniew Lukwinski <[email protected]>
zlukwins
force-pushed
the
fix-compilations-warnings-in-libraries
branch
from
1d0712c to
deccdd0
Compare
jyao1
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are a fixup for the #155 and #156
It turned out that cherry-picking patches is not aligned with current CI workflow where fetching very limited number of revisions (branches, tags, sha, etc.).
Thus reverting previous commits and bringing new ones based on keeping the patches locally in the repository